On Thu, Jan 02, 2025 at 04:45:07PM -0400, Jason Gunthorpe wrote: > On Tue, Dec 17, 2024 at 09:00:19PM -0800, Nicolin Chen wrote: > > Allow a vIOMMU object to allocate vIRQ Event Queues, with a condition that > > each vIOMMU can only have one single vIRQ event queue per type. > > I suggest you should tend to use the eventq as the primary naming not > vIRQ, I think that will be a bit clearer. > > The virq in the VM is edge triggered by an event queue FD becoming > readable, but the event queue is the file descriptor that reports a > batch of events on read(). > > The virq name evokes similarities to the virq in vfio which is purely > about conveying if an IRQ edge has happened through an eventfd and has > no event queue associated with it. Ack. By doing the "Part-3: vEVENTQ" specifying one type of queue, I think the Part-4 then should be "vCMDQ" likewise v.s. "vQUEUE". Thanks Nicolin
