Jakub Kicinski wrote: > On Tue, 17 Dec 2024 18:51:57 +0000 Soham Chakradeo wrote: > > Import tests for the following features (folder names in brackets): > > ECN (ecn) : RFC 3168 > > Close (close) : RFC 9293 > > TCP_INFO (tcp_info) : RFC 9293 > > Fast recovery (fast_recovery) : RFC 5681 > > Timestamping (timestamping) : RFC 1323 > > Nagle (nagle) : RFC 896 > > Selective Acknowledgments (sack) : RFC 2018 > > Recent Timestamp (ts_recent) : RFC 1323 > > Send file (sendfile) > > Syscall bad arg (syscall_bad_arg) > > Validate (validate) > > Blocking (blocking) > > Splice (splice) > > End of record (eor) > > Limited transmit (limited_transmit) > > Excellent, thanks for adding all these! I will merge the patches > momentarily but I do see a number of flakes on our VMs with debug > configs enabled: > https://netdev.bots.linux.dev/flakes.html?min-flip=0&tn-needle=packetdrill-dbg > > In the 7 runs so far we got 2 flakes on: > > tcp-timestamping-client-only-last-byte-pkt > tcp-fast-recovery-prr-ss-ack-below-snd-una-cubic-pkt > tcp-timestamping-server-pkt > > 1 flake on: > > tcp-timestamping-partial-pkt > tcp-eor-no-coalesce-retrans-pkt > > LMK if you can't find the outputs, they should be there within a couple > of clicks. > > I'll set these cases to be ignored for now, but would be great if we > could find the way for them to be less time sensitive, perhaps? Yes, let's get a bit more data how flaky they are and investigate. Hopefully it's just tuning. Worst case we could back out these few tests (temporarily) to avoid polluting the dash. We did not observe this on our end during repeated debug runs.
