Madhavan Srinivasan <maddy@xxxxxxxxxxxxx> writes: > core-pkey.c test has couple of macros defined which > are part of "pkeys.h" header file. Remove those > duplicates and include "pkeys.h" > > Signed-off-by: Madhavan Srinivasan <maddy@xxxxxxxxxxxxx> > --- > .../selftests/powerpc/ptrace/core-pkey.c | 19 +------------------ > 1 file changed, 1 insertion(+), 18 deletions(-) .../powerpc/ptrace/Makefile includes flags.mk. In .../powerpc/flags.mk we anyways add -I$(selfdir)/powerpc/include in CFLAGS - so it will pick up the header files defined in powerpc/include. It make sense to clean this up and consolidate the common header definitions into pkeys.h header file. The changes looks good to me. Please feel free to add - Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@xxxxxxxxx> -ritesh
