> From: Nicolin Chen <nicolinc@xxxxxxxxxx> > Sent: Wednesday, December 4, 2024 6:10 AM > > +static int iommufd_fault_init(struct iommufd_fault *fault, char *name, > + struct iommufd_ctx *ictx) > +{ > + struct file *filep; > + int fdno; > + > + fault->ictx = ictx; while at it could you move this line behind iommufd_ctx_get(fault->ictx). usually we want the two together. Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>