Re: [PATCH v2 net-next] wireguard: allowedips: Add WGALLOWEDIP_F_REMOVE_ME flag

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Better still use NLA_POLICY_MASK() so that nla_parse_nested() can
> perform the validation and attach a machine readable info about
> the failure.

This is definitely cleaner for the new WGALLOWEDIP_A_FLAGS parameter.
Thanks for the suggestion.

Applying this to WGPEER_A_FLAGS would simplify the existing validation
logic as well, although I think it changes the error code returned if
a user provides an invalid flag from EOPNOTSUPP to EINVAL. I'm not
sure if there's anything relying on this behavior. I'll let Jason make
the final call there.

-Jordan




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux