On 26/11/2024 09:17, Antonio Quartulli wrote:
[...]
It wasn't suggested to destroy the interface in case of interface
becoming non-operational. I apologize if something I wrote earlier
sounded like that. The interface existence stays unquestionable. It's
going to be solid persistent.
Back to the proposed rephrasing. If the 'full picture' means forcing
the running state indication even when the netdev is not capable to
deliver packets, then it looks like an attempt to hide the control
knob of the misguiding feature somewhere else.
And since the concept of on-purpose false indication is still here,
many words regarding the control plane and a full picture do not sound
good either.
Sergey,
I have played a bit with this and, if I understood your idea correctly,
the following should be an acceptable design for a P2P interface:
* iface created -> netif_carrier_off
* peer added -> netif_carrier_on
* peer deleted -> netif_carrier_off
* iface goes down -> peer deleted -> netif_carrier_off
* iface goes up -> carrier stays down until peer is added
P2MP interface behaviour is not changed: when interface is brought up
carrier goes on and it is never turned off.
How does it sound?
My main concern was about bringing the interface down, but this is
actually not happening. Correct me if I am wrong.
Thanks.
Regards,
--
Antonio Quartulli
OpenVPN Inc.
