Re: [PATCH bpf-next 03/10] selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Alexis Lothoré (eBPF Foundation) <alexis.lothore@xxxxxxxxxxx>
Subject: Re: [PATCH bpf-next 03/10] selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test
From: Stanislav Fomichev <stfomichev@xxxxxxxxx>
Date: Wed, 13 Nov 2024 09:34:43 -0800
Cc: Andrii Nakryiko <andrii@xxxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, ebpf@xxxxxxxxxxxxxxxxxxx, Thomas Petazzoni <thomas.petazzoni@xxxxxxxxxxx>, Bastien Curutchet <bastien.curutchet@xxxxxxxxxxx>, Petar Penkov <ppenkov@xxxxxxxxxx>, bpf@xxxxxxxxxxxxxxx, linux-kselftest@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx
In-reply-to: <20241113-flow_dissector-v1-3-27c4df0592dc@bootlin.com>

On 11/13, Alexis Lothoré (eBPF Foundation) wrote:
> The flow dissector test currently relies on generic CHECK macros to
> perform tests. Update those to newer, more-specific ASSERT macros.
> 
> This update allows to get rid of the global duration variable, which was
> needed by the CHECK macros
> 
> Signed-off-by: Alexis Lothoré (eBPF Foundation) <alexis.lothore@xxxxxxxxxxx>

Acked-by: Stanislav Fomichev <sdf@xxxxxxxxxxx>

References:
- [PATCH bpf-next 00/10] selftests/bpf: migrate test_flow_dissector.sh to test_progs
  - From: Alexis Lothoré (eBPF Foundation)
- [PATCH bpf-next 03/10] selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test
  - From: Alexis Lothoré (eBPF Foundation)

Prev by Date: Re: [PATCH bpf-next 02/10] selftests/bpf: use ASSERT_MEMEQ to compare bpf flow keys
Next by Date: Re: [PATCH bpf-next 04/10] selftests/bpf: re-split main function into dedicated tests
Previous by thread: [PATCH bpf-next 03/10] selftests/bpf: replace CHECK calls with ASSERT macros in flow_dissector test
Next by thread: [PATCH bpf-next 05/10] selftests/bpf: expose all subtests from flow_dissector
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]