Wed, Nov 06, 2024 at 10:17:06AM CET, danishanwar@xxxxxx wrote: >This series adds VLAN support to HSR framework. >This series also adds VLAN support to HSR mode of ICSSG Ethernet driver. > >Changes from v2 to v3: >*) Modified hsr_ndo_vlan_rx_add_vid() to handle arbitrary HSR_PT_SLAVE_A, >HSR_PT_SLAVE_B order and skip INTERLINK port in patch 2/4 as suggested by >Paolo Abeni <pabeni@xxxxxxxxxx> >*) Removed handling of HSR_PT_MASTER in hsr_ndo_vlan_rx_kill_vid() as MASTER >and INTERLINK port will be ignored anyway in the default switch case as >suggested by Paolo Abeni <pabeni@xxxxxxxxxx> >*) Modified the selftest in patch 4/4 to use vlan by default. The test will >check the exposed feature `vlan-challenged` and if vlan is not supported, skip >the vlan test as suggested by Paolo Abeni <pabeni@xxxxxxxxxx>. Test logs can be >found at [1] > >Changes from v1 to v2: >*) Added patch 4/4 to add test script related to VLAN in HSR as asked by >Lukasz Majewski <lukma@xxxxxxx> > >[1] https://gist.githubusercontent.com/danish-ti/d309f92c640134ccc4f2c0c442de5be1/raw/9cfb5f8bd12b374ae591f4bd9ba3e91ae509ed4f/hsr_vlan_logs >v1 https://lore.kernel.org/all/20241004074715.791191-1-danishanwar@xxxxxx/ >v2 https://lore.kernel.org/all/20241024103056.3201071-1-danishanwar@xxxxxx/ > >MD Danish Anwar (1): > selftests: hsr: Add test for VLAN > >Murali Karicheri (1): > net: hsr: Add VLAN CTAG filter support > >Ravi Gunasekaran (1): > net: ti: icssg-prueth: Add VLAN support for HSR mode > >WingMan Kwok (1): > net: hsr: Add VLAN support > > drivers/net/ethernet/ti/icssg/icssg_prueth.c | 45 ++++++++- > net/hsr/hsr_device.c | 85 +++++++++++++++-- > net/hsr/hsr_forward.c | 19 +++- > tools/testing/selftests/net/hsr/config | 1 + > tools/testing/selftests/net/hsr/hsr_ping.sh | 98 ++++++++++++++++++++ > 5 files changed, 236 insertions(+), 12 deletions(-) Looks fine to me. set- Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx>
