On Mon, Nov 04, 2024 at 10:14:23AM -0800, Stanislav Fomichev wrote: > To make it clear what's required and what's not. Also, some of the > values don't seem like a good defaults; for example eth1. > > Move the invocation comment to the top, add missing -s to the client > and cleanup the client invocation a bit to make more readable. > > Reviewed-by: Mina Almasry <almasrymina@xxxxxxxxxx> > Signed-off-by: Stanislav Fomichev <sdf@xxxxxxxxxxx> > --- > tools/testing/selftests/net/ncdevmem.c | 61 ++++++++++++++++---------- > 1 file changed, 39 insertions(+), 22 deletions(-) Reviewed-by: Joe Damato <jdamato@xxxxxxxxxx>