On Fri, Nov 1, 2024 at 4:14 AM Yunsheng Lin <linyunsheng@xxxxxxxxxx> wrote: > > On 2024/10/30 4:45, Mina Almasry wrote: > > Create page_pool_alloc_netmem to be the mirror of page_pool_alloc. > > > > This enables drivers that want currently use page_pool_alloc to > > transition to netmem by converting the call sites to > > page_pool_alloc_netmem. > > For old API, page_pool_alloc_pages() always return a whole page, and > page_pool_alloc() returns a whole page or a page fragment based on the > requested size. > > For new netmem API, page_pool_alloc_netmems() always return a whole > netmem, and page_pool_alloc_netmem() returns a whole netmem or a netmem > fragment based on the requested size. > > Isn't it a little odd that old and new are not following the same > pattern? Hi Yunsheng, The intention is that page_pool_alloc_pages is mirrored by page_pool_alloc_netmems. And page_pool_alloc is mirrored by page_pool_alloc_netmem.