On Mon, Oct 28, 2024 at 02:26:44PM +0000, Mark Rutland wrote: > 1) We only singal the tasks once a second. Dave's original shell test > script hammered this constantly, and it makes a substantial impact > actually triggering a bug. > Without these patches, I hacked the fp-stress.c main loop to trigger > a signal every ~1ms (by reducing the epoll_wait() timeout to 1 and > scaling the overall timeout to 10000 accordingly), and those changes > make the tests reliably trigger the "Bad SVCR" splats within a few > seconds after a few hundred signals, even if only using the SIGUSR2 > tickle handlers. > Can we change the fp-stress.c main loop to signal threads more often? Yeah, the once a second number was kind of pulled out of thin air (IIRC I originally picked that for UI purposes and then added the signalling later without specific purpose, I wasn't particularly referencing the shell scripts here since I never used them much). I don't see any reason not to raise the rate, we do need it to be low enough to allow the main loops of the test programs to make reasonable progress so miliseconds feels like it might be a bit aggressive for a fully loaded FVP configuration. That'd be a separate patch anyway. > 2) The SIGUSR2 tickle handlers are left behind. > Given they're unused, it'd be nice to clean them up. I don't see an urgent need to remove them, like the SIGUSR1 handlers previously they're not doing any harm sitting there and could come in handy when debugging things - the programs get a reasonable amount of use standalone.
Attachment:
signature.asc
Description: PGP signature
