> From: Nicolin Chen <nicolinc@xxxxxxxxxx> > Sent: Saturday, October 26, 2024 7:50 AM > > + * @viommu_alloc: Allocate an iommufd_viommu on a physical IOMMU > instance behind > + * the @dev, as the set of virtualization resources shared/passed > + * to user space IOMMU instance. And associate it with a nesting > + * @parent_domain. The @viommu_type must be defined in the > header > + * include/uapi/linux/iommufd.h > + * It is suggested to call iommufd_viommu_alloc() helper for > + * a bundled allocation of the core and the driver structures, > + * using the given @ictx pointer. s/suggested/required/? Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>