On 10/22/24 08:50, Petr Machata wrote:
Many net selftests invent their own logging helpers. These really should be in a library sourced by these tests. Currently forwarding/lib.sh has a suite of perfectly fine logging helpers, but sourcing a forwarding/ library from a higher-level directory smells of layering violation. In this patch, move the logging helpers to net/lib.sh so that every net test can use them. Together with the logging helpers, it's also necessary to move pause_on_fail(), and EXIT_STATUS and RET. Existing lib.sh users might be using these same names for their functions or variables. However lib.sh is always sourced near the top of the file (checked), and whatever new definitions will simply override the ones provided by lib.sh.
I like the direction to leverage and make logging functions common. It make sense to use prefix to clearly indicate that they are common and to namespace conflicts in the future.
Signed-off-by: Petr Machata <petrm@xxxxxxxxxx> Reviewed-by: Amit Cohen <amcohen@xxxxxxxxxx> --- CC: Shuah Khan <shuah@xxxxxxxxxx>
Acked-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> for all patches 4/8 through 8/8 I have been cc'ed on. thanks, -- Shuah
