Hi Johannes, On Tue, 22 Oct 2024 at 19:36, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > On Tue, Oct 22, 2024 at 05:51:58PM +0530, Pintu Kumar wrote: > > There is a psi module that exists under kernel/sched/psi. > > Add a basic test to test the psi. > > I'm not sure this is a valuable use of test cycles. The mere existence > and basic format of the files is very unlikely to be buggy, and such a > bug wouldn't hide for very long either. > Yes, I agree this is just a basic version to prepare for the test framework. Once the framework is available more tests can be added, such as trigger poll. If you have any other suggestions for the test please let me know. > > @@ -18548,10 +18548,12 @@ F: include/uapi/linux/pps.h > > PRESSURE STALL INFORMATION (PSI) > > M: Johannes Weiner <hannes@xxxxxxxxxxx> > > M: Suren Baghdasaryan <surenb@xxxxxxxxxx> > > +M: Pintu Kumar <quic_pintu@xxxxxxxxxxx> > > $ git log --oneline --author='Pintu Kumar' kernel/sched/psi.c | wc -l > 0 > > Really? ;) > oh sorry. This maintainer was added for tools/testing/sefttests/sched/psi_test after referring to existing once. Otherwise, checkpatch was giving below warning: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #51: new file mode 100644 total: 0 errors, 1 warnings, 134 lines checked Please let me know what is the correct way. Thanks, Pintu
