On 10/11/24 18:47, John Stultz wrote:
On Fri, Oct 11, 2024 at 4:00 PM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote:
On 10/10/24 01:37, Chen Ni wrote:
Remove unnecessary semicolons reported by Coccinelle/coccicheck and the
semantic patch at scripts/coccinelle/misc/semicolon.cocci.
Signed-off-by: Chen Ni <nichen@xxxxxxxxxxx>
---
tools/testing/selftests/timers/set-timer-lat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/testing/selftests/timers/set-timer-lat.c b/tools/testing/selftests/timers/set-timer-lat.c
index 5365e9ae61c3..7a1a2382538c 100644
--- a/tools/testing/selftests/timers/set-timer-lat.c
+++ b/tools/testing/selftests/timers/set-timer-lat.c
@@ -79,7 +79,7 @@ char *clockstring(int clockid)
return "CLOCK_BOOTTIME_ALARM";
case CLOCK_TAI:
return "CLOCK_TAI";
- };
+ }
return "UNKNOWN_CLOCKID";
}
Looks good to me.
John, I will apply this for next of you are okay with it.
Acked-by: John Stultz <jstultz@xxxxxxxxxx>
Thank you. Applied linux-kselftest next for Linux 6.13-rc1.
Also I noticed clockstring() is defined in multiple tests.
Any thoughts on removing the duplicates and adding it to
a header file? This will add a dependency on another source
file, but might be good to remove the duplicate code.
Sure, no objections.
Thanks. I will send patch in soon.
thanks,
-- Shuah
