On Fri, Oct 11, 2024 at 03:25:07PM +0800, David Gow wrote: > From: Kees Cook <kees@xxxxxxxxxx> > > Following from the recent KUnit file naming discussion[1], move all > KUnit tests in lib/ into lib/tests/. > > Link: https://lore.kernel.org/lkml/20240720165441.it.320-kees@xxxxxxxxxx/ [1] > Signed-off-by: Kees Cook <kees@xxxxxxxxxx> > Acked-by: "Steven Rostedt (Google)" <rostedt@xxxxxxxxxxx> > Acked-by: Jakub Kicinski <kuba@xxxxxxxxxx> > Acked-by: "Masami Hiramatsu (Google)" <mhiramat@xxxxxxxxxx> > Reviewed-by: David Gow <davidgow@xxxxxxxxxx> > [Rebased onto mm-nonmm-unstable, moved usercopy_kunit] > Signed-off-by: David Gow <davidgow@xxxxxxxxxx> > rename lib/{ => tests}/bitfield_kunit.c (100%) > rename lib/{ => tests}/checksum_kunit.c (100%) > rename lib/{ => tests}/cmdline_kunit.c (100%) > rename lib/{ => tests}/cpumask_kunit.c (100%) > rename lib/{ => tests}/fortify_kunit.c (100%) > rename lib/{ => tests}/hashtable_test.c (100%) > rename lib/{ => tests}/is_signed_type_kunit.c (100%) > rename lib/{ => tests}/kunit_iov_iter.c (100%) > rename lib/{ => tests}/list-test.c (100%) > rename lib/{ => tests}/memcpy_kunit.c (100%) > rename lib/{ => tests}/overflow_kunit.c (100%) > rename lib/{ => tests}/siphash_kunit.c (100%) > rename lib/{ => tests}/slub_kunit.c (100%) > rename lib/{ => tests}/stackinit_kunit.c (100%) > rename lib/{ => tests}/string_helpers_kunit.c (100%) > rename lib/{ => tests}/string_kunit.c (100%) > rename lib/{ => tests}/test_bits.c (100%) > rename lib/{ => tests}/test_fprobe.c (100%) > rename lib/{ => tests}/test_hash.c (100%) > rename lib/{ => tests}/test_kprobes.c (100%) > rename lib/{ => tests}/test_linear_ranges.c (100%) > rename lib/{ => tests}/test_list_sort.c (100%) > rename lib/{ => tests}/test_sort.c (100%) > rename lib/{ => tests}/usercopy_kunit.c (100%) While I support the idea, I think this adds an additional churn in creating a duplicate 'test' in the filenames. Why they all can't be cut while removing? (at least this question is not answered in the commit message) -- With Best Regards, Andy Shevchenko
