On 24/10/09 07:32, Jakub Kicinski wrote: > On Wed, 9 Oct 2024 00:01:33 +0200 Alessandro Zanni wrote: > > This fix solves this error, when calling kselftest with targets "drivers/net": > > > > File "tools/testing/selftests/net/lib/py/nsim.py", line 64, in __init__ > > if e.errno == errno.ENOSPC: > > NameError: name 'errno' is not defined > > > > The module errno makes available standard error system symbols. > > Can you say more about how you hit this error? > > If it's just based on static analysis please mention that in the commit > message, and also mention that the problem doesn't happen in practice. > This will avoid the patch being backported unnecessarily. I didn't use static analysis tool. I've run the test manually. I got the error from executing: make --silent kselftest TARGETS="drivers/net" Thanks for pointing out, I'll prepare a v2 patch with the command used. > We run all the tests in our CI, and the problem is not hit. But I agree > with you that the import is theoretically missing. When I ran the test, the function ctrl_write() raised an OSError. So, in my case, it was also a practical error. > -- > pw-bot: cr
