> From: Liu, Yi L <yi.l.liu@xxxxxxxxx> > Sent: Thursday, September 12, 2024 9:07 PM > > The iommu drivers are on the way to drop the remove_dev_pasid op by > extending the blocked_domain to support PASID. However, this cannot be > done in one shot. So far, the Intel iommu and the ARM SMMUv3 driver have > supported it, while the AMD iommu driver has not yet. During this > transition, the IOMMU core needs to support both ways to destroy the > attachment of device/PASID and domain. > > Signed-off-by: Yi Liu <yi.l.liu@xxxxxxxxx> > --- > drivers/iommu/iommu.c | 30 ++++++++++++++++++++++++------ > 1 file changed, 24 insertions(+), 6 deletions(-) > > diff --git a/drivers/iommu/iommu.c b/drivers/iommu/iommu.c > index f3f81c04b8fb..b6b44b184004 100644 > --- a/drivers/iommu/iommu.c > +++ b/drivers/iommu/iommu.c > @@ -3324,6 +3324,28 @@ bool iommu_group_dma_owner_claimed(struct > iommu_group *group) > } > EXPORT_SYMBOL_GPL(iommu_group_dma_owner_claimed); > > +/* > + * This is only needed in the transition of dropping remove_dev_pasid op > + * by adding set_dev_pasid op for the blocked domains. > + */ let's be specific that it's gated by AMD's support and temporary. with the order adjusted as Baolu suggested: Reviewed-by: Kevin Tian <kevin.tian@xxxxxxxxx>