On Wed, Sep 25, 2024 at 02:05:39PM +0900, Kacper Ludwinski wrote:
> Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test")
> Signed-off-by: Kacper Ludwinski <kacper@xxxxxxxxxxxxx>
> ---
> tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
...
Hi Kacper,
Thanks for your patch.
Some feedback in process:
* Please do not post updated versions of patches within 24h of each
other.
* Please do post new versions of patches in new threads,
with appropriate versions in the subject (v2 in this case).
And some text under the scissors ('---') describing that the change is.
b4 will handle this for you.
* Please include some text in the commit message,
in this case describing the problem that is being resolved.
* Please tag patches for Networking as being targeted at either
the net or net-next trees.
Subject: [PATCH net v2] ...
* Please refer to git history and include an appropriate prefix
in the subject of the patch. In this case it looks like
it should be 'selftests: forwarding:'
Subject: [PATCH net v2] selftests: forwarding: ...
* Please consider reading the netdev maintainers process guide
https://docs.kernel.org/process/maintainer-netdev.html
Lastly, there is a spelling error in the subject.
checkpatch.pl --codespell flagged this.
--
pw-bot: changes-requested
