On Tue, Sep 24, 2024 at 8:57 AM Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx> wrote: > > Remove local NSEC_PER_SEC and USEC_PER_SEC defines. Pick them up from > include/vdso/time64.h. This requires -I $(top_srcdir) to the timers > Makefile to include the include/vdso/time64.h. > > posix_timers test names the defines NSECS_PER_SEC and USECS_PER_SEC. > Include the include/vdso/time64.h and change NSECS_PER_SEC and > USECS_PER_SEC references to NSEC_PER_SEC and USEC_PER_SEC respectively. Nit: You got the last bit switched there. This patch changes local NSEC_PER_SEC to the upstream defined NSECS_PER_SEC. Overall no objection from me. I've always pushed to have the tests be mostly self-contained so they can be built outside of the kernel source, but at this point the current kselftest.h dependencies means it already takes some work, so this isn't introducing an undue hardship. Other then the nit, Acked-by: John Stultz <jstultz@xxxxxxxxxx> > diff --git a/tools/testing/selftests/timers/adjtick.c b/tools/testing/selftests/timers/adjtick.c > index 205b76a4abb4..cb9a30f54662 100644 > --- a/tools/testing/selftests/timers/adjtick.c > +++ b/tools/testing/selftests/timers/adjtick.c > @@ -22,14 +22,12 @@ > #include <sys/time.h> > #include <sys/timex.h> > #include <time.h> > +#include <include/vdso/time64.h> > > #include "../kselftest.h" > > #define CLOCK_MONOTONIC_RAW 4 I suspect CLOCK_MONOTONIC_RAW (and the other clockid definitions) could be similarly removed here as well in a future patch? thanks -john
