Re: [PATCH 0/1] Add KUnit tests for lib/crc16.c

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hey!

On 9/23/24 01:26, Vinicius Peixoto wrote:
Hi all,

This patch was developed during a hackathon organized by LKCAMP [1],
with the objective of writing KUnit tests, both to introduce people to
the kernel development process and to learn about different subsystems
(with the positive side effect of improving the kernel test coverage, of
course).

We noticed there were tests for CRC32 in lib/crc32test.c and thought it
would be nice to have something similar for CRC16, since it seems to be
widely used in network drivers (as well as in some ext4 code).

Although this patch turned out quite big, most of the LOCs come from
tables containing randomly-generated test data that we use to validate
the kernel's implementation of CRC-16.
Can you share how you created the tables? Given that is impossible to review the table itself, at least people will be able to see how they got created at least.
We would really appreciate any feedback/suggestions on how to improve
this. Thanks! :-)

Vinicius Peixoto (1):
   lib/crc16_kunit.c: add KUnit tests for crc16

  lib/Kconfig.debug |   8 +
  lib/Makefile      |   1 +
  lib/crc16_kunit.c | 715 ++++++++++++++++++++++++++++++++++++++++++++++
  3 files changed, 724 insertions(+)
  create mode 100644 lib/crc16_kunit.c





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux