Re: [PATCH] damon: access_memory_even: remove unused variables

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Ba,

On Tue,  3 Sep 2024 11:43:00 +0800 Ba Jing <bajing@xxxxxxxxxxxxxxxxxxxx> wrote:

> These variables are never referenced in the code, just remove it.

Nice finding, thank you!

I'd prefer having 'selftests/damon/access_memory_even: ' as the commit subject
prefix.

> 
> Signed-off-by: Ba Jing <bajing@xxxxxxxxxxxxxxxxxxxx>

Other than the above trivial nitpick,

Reviewed-by: SeongJae Park <sj@xxxxxxxxxx>


Thanks,
SJ

> ---
>  tools/testing/selftests/damon/access_memory_even.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/tools/testing/selftests/damon/access_memory_even.c b/tools/testing/selftests/damon/access_memory_even.c
> index 3be121487432..a9f4e9aaf3a9 100644
> --- a/tools/testing/selftests/damon/access_memory_even.c
> +++ b/tools/testing/selftests/damon/access_memory_even.c
> @@ -14,10 +14,8 @@
>  int main(int argc, char *argv[])
>  {
>  	char **regions;
> -	clock_t start_clock;
>  	int nr_regions;
>  	int sz_region;
> -	int access_time_ms;
>  	int i;
>  
>  	if (argc != 3) {
> -- 
> 2.33.0




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux