On 2024/9/13 10:11, Baolu Lu wrote:
On 9/12/24 9:04 PM, Yi Liu wrote:
diff --git a/drivers/iommu/intel/pasid.c b/drivers/iommu/intel/pasid.c
index b51fc268dc84..ceb9c5274a39 100644
--- a/drivers/iommu/intel/pasid.c
+++ b/drivers/iommu/intel/pasid.c
@@ -236,8 +236,13 @@ devtlb_invalidation_with_pasid(struct intel_iommu
*iommu,
qi_flush_dev_iotlb_pasid(iommu, sid, pfsid, pasid, qdep, 0, 64
- VTD_PAGE_SHIFT);
}
+/*
+ * Not all PASID entry destroy requires PRQ drain as it can be handled in
+ * the remove_dev_pasid path. Caller should be clear about it and set the
+ * @flags properly.
+ */
void intel_pasid_tear_down_entry(struct intel_iommu *iommu, struct
device *dev,
- u32 pasid, bool fault_ignore)
+ u32 pasid, u32 flags)
As a generic opt-in bit flags, why not using 'unsigned int'?
aha, I can use 'unsigned int'.
--
Regards,
Yi Liu
