Jakub Kicinski wrote:
> On Thu, 5 Sep 2024 19:15:50 -0400 Willem de Bruijn wrote:
> > Lay the groundwork to import into kselftests the over 150 packetdrill
> > TCP/IP conformance tests on github.com/google/packetdrill.
> >
> > 1/2: add kselftest infra for TEST_PROGS that need an interpreter
> >
> > 2/2: add the specific packetdrill tests
> >
> > Both can go through net-next, I imagine. But let me know if the
> > core infra should go through linux-kselftest.
>
> Okay, looks like the set has survived DaveM's weekend cleanup of
> patchwork :) I'm planning to apply it in the afternoon (Pacific
> time), please LMK if anyone has objections / needs more time to
> review. I'm expecting 'unshare -n' as a follow up.
Which literally just inserting uname -n into the two invocations,
right?
+++ b/tools/testing/selftests/net/packetdrill/ksft_runner.sh
@@ -33,9 +33,9 @@ fi
ktap_print_header
ktap_set_plan 2
-packetdrill ${ipv4_args[@]} $(basename $script) > /dev/null \
+unshare -n packetdrill ${ipv4_args[@]} $(basename $script) > /dev/null \
&& ktap_test_pass "ipv4" || ktap_test_fail "ipv4"
-packetdrill ${ipv6_args[@]} $(basename $script) > /dev/null \
+unshare -n packetdrill ${ipv6_args[@]} $(basename $script) > /dev/null \
&& ktap_test_pass "ipv6" || ktap_test_fail "ipv6"
I can send that. And then also add some CONFIGs we discussed:
+++ b/tools/testing/selftests/net/packetdrill/config
@@ -1,5 +1,10 @@
CONFIG_IPV6=y
+CONFIG_HZ_1000=y
+CONFIG_HZ=1000
+CONFIG_NET_NS=y
CONFIG_NET_SCH_FIFO=y
CONFIG_PROC_SYSCTL=y
+CONFIG_SYN_COOKIES=y
+CONFIG_TCP_CONG_CUBIC=y
CONFIG_TCP_MD5SIG=y
CONFIG_TUN=y
And in the same series another two packetdrill testsuites, around 20
tests, say.
