Re: [PATCH v2] selftests/timers: Remove unused NSEC_PER_SEC macro

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 9/5/24 20:52, zhangjiao2 wrote:
From: zhang jiao <zhangjiao2@xxxxxxxxxxxxxxxxxxxx>

By readind the code, I found the macro NSEC_PER_SEC

reading

is never referenced in the code. Just remove it.

Signed-off-by: zhang jiao <zhangjiao2@xxxxxxxxxxxxxxxxxxxx>

Running checkpatch can catch spelling errors.

---
v1->v2:
	Put together files with similar problems

  tools/testing/selftests/timers/change_skew.c      | 3 ---
  tools/testing/selftests/timers/skew_consistency.c | 2 --
  2 files changed, 5 deletions(-)

diff --git a/tools/testing/selftests/timers/change_skew.c b/tools/testing/selftests/timers/change_skew.c
index 4421cd562c24..18e794a46c23 100644
--- a/tools/testing/selftests/timers/change_skew.c
+++ b/tools/testing/selftests/timers/change_skew.c
@@ -30,9 +30,6 @@
  #include <time.h>
  #include "../kselftest.h"
-#define NSEC_PER_SEC 1000000000LL
-
-
  int change_skew_test(int ppm)
  {
  	struct timex tx;
diff --git a/tools/testing/selftests/timers/skew_consistency.c b/tools/testing/selftests/timers/skew_consistency.c
index c8e6bffe4e0a..83450145fe65 100644
--- a/tools/testing/selftests/timers/skew_consistency.c
+++ b/tools/testing/selftests/timers/skew_consistency.c
@@ -36,8 +36,6 @@
  #include <sys/wait.h>
  #include "../kselftest.h"
-#define NSEC_PER_SEC 1000000000LL
-
  int main(int argc, char **argv)
  {
  	struct timex tx;

This looks good to me.

Reviewed-by: Shuah Khan <skhan@xxxxxxxxxxxxxxxxxxx>

John, I can pick this up with if you are okay with this change.

thanks,
-- Shuah




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux