On Thu, Sep 5, 2024 at 10:45 PM Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx> wrote: > > Jason Xing wrote: > > On Thu, Sep 5, 2024 at 9:38 PM Willem de Bruijn > > <willemdebruijn.kernel@xxxxxxxxx> wrote: > > > > > > Jason Xing wrote: > > > > From: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > > > > > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the > > > > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or > > > > SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time. > > > > > > > > So let us revise the doc here. > > > > > > > > Suggested-by: Willem de Bruijn <willemdebruijn.kernel@xxxxxxxxx> > > > > Signed-off-by: Jason Xing <kernelxing@xxxxxxxxxxx> > > > > > > Reviewed-by: Willem de Bruijn <willemb@xxxxxxxxxx> > > > > > > As an exception to the rule, as a one word fix, can be squashed into > > > the feature patch, I think. > > > > > > > --- > > > > Link: https://lore.kernel.org/all/66d8c21d3042a_163d93294cb@xxxxxxxxxxxxxxxxxxxxxx.notmuch/ > > > > > > Please put these at the top of the Suggested-by/Signed-off-by/..-by > > > block. Their more useful to future readers than to current followers > > > of the mailing list. > > > > But I have to ask if it looks a little messy if the first patch will > > grow much bigger than before with adding some suggested-by tags and > > links, and a separate paragraph to explain why we touch the doc... > > > > Cooking one patch which saves my much energy is surely easier for me > > but not for readers probably, I assume. > > Ok. This small patch can even be stand-alone. No need for a series. > Got it. I will send it as a standalone patch tomorrow since I need to wait more than 24 hours.
