On Thu, Sep 05, 2024 at 11:26:02AM +0530, Dev Jain wrote: > On 9/4/24 22:35, Shuah Khan wrote: > > So who does the backports whenevenr something changes? You are adding > > work where as the automated process would just work without this > > change. It doesn't matter if there is another test that changed > > the name. I thought git was supposed to have some ability to try to cope with renames, though heuristic based? It does seem to work sometimes. TBH I'm also not sure how frequent an issue backporting fixes to this one test is going to be, it's had a couple of minor fixes for warnings in the past few years and the last substantial update was in 2021. > > > > If this new test has no relation to sigaltstack, then why are you > > changing > > and renaming the sigaltstack directory? > Because the functionality I am testing is of signals, and signals are a > superset > of sigaltstack. Still, I can think of a compromise, if semantically you want I do tend to agree here, it seems neater to merge things and from the point of view of running the tests in CI it's nice to not have too many tiny suites, they create runtime overhead. > to > consider the new test as not testing signals, but a specific syscall > "sigaction" > and its interaction with blocking of signals, how about naming the new > directory "sigaction"? That's not going to scale amazingly if we test any other aspects of signals... I'd just call it "signal" and if it's not possible to get the merge done just leave the sigaltstack suite as it is.
Attachment:
signature.asc
Description: PGP signature
