Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx>
Subject: Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
From: Alexei Starovoitov <alexei.starovoitov@xxxxxxxxx>
Date: Fri, 30 Aug 2024 18:24:47 -0700
Cc: Tony Ambardar <tony.ambardar@xxxxxxxxx>, Alexei Starovoitov <ast@xxxxxxxxxx>, bpf <bpf@xxxxxxxxxxxxxxx>, "open list:KERNEL SELFTEST FRAMEWORK" <linux-kselftest@xxxxxxxxxxxxxxx>, Andrii Nakryiko <andrii@xxxxxxxxxx>, Eduard Zingerman <eddyz87@xxxxxxxxx>, Daniel Borkmann <daniel@xxxxxxxxxxxxx>, Martin KaFai Lau <martin.lau@xxxxxxxxx>, Song Liu <song@xxxxxxxxxx>, Yonghong Song <yonghong.song@xxxxxxxxx>, John Fastabend <john.fastabend@xxxxxxxxx>, KP Singh <kpsingh@xxxxxxxxxx>, Stanislav Fomichev <sdf@xxxxxxxxxxx>, Hao Luo <haoluo@xxxxxxxxxx>, Jiri Olsa <jolsa@xxxxxxxxxx>, Mykola Lysenko <mykolal@xxxxxx>, Shuah Khan <shuah@xxxxxxxxxx>, Ilya Leoshkevich <iii@xxxxxxxxxxxxx>, Quentin Monnet <qmo@xxxxxxxxxx>
In-reply-to: <CAEf4Bzb++vMkc=Q44QhQ5BXJcnUWahVtBUgQBUwkdVvC1QYKnQ@mail.gmail.com>

On Fri, Aug 30, 2024 at 2:31 PM Andrii Nakryiko
<andrii.nakryiko@xxxxxxxxx> wrote:
>
>
>
> for the rest, Alexei, can you please review and give your ack?

It looks fine.
All of the additional pr_debug()s look a bit excessive.
Will take another look at respin.

Follow-Ups:
- Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
  - From: Tony Ambardar

References:
- [PATCH bpf-next v4 0/8] libbpf, selftests/bpf: Support cross-endian usage
  - From: Tony Ambardar
- [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
  - From: Tony Ambardar
- Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
  - From: Andrii Nakryiko

Prev by Date: Re: [PATCH bpf-next v4 5/8] libbpf: Support opening bpf objects of either endianness
Next by Date: Re: [PATCH bpf-next v4 5/8] libbpf: Support opening bpf objects of either endianness
Previous by thread: Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
Next by thread: Re: [PATCH bpf-next v4 7/8] libbpf: Support creating light skeleton of either endianness
Index(es):
- Date
- Thread

[Index of Archives] [Linux Wireless] [Linux Kernel] [ATH6KL] [Linux Bluetooth] [Linux Netdev] [Kernel Newbies] [Share Photos] [IDE] [Security] [Git] [Netfilter] [Bugtraq] [Yosemite News] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Linux ATA RAID] [Samba] [Device Mapper]