On Fri, Aug 30, 2024 at 05:54:35PM +0200, Jason A. Donenfeld wrote: > From: Mark Brown <broonie@xxxxxxxxxx> > > Unlike the check for the standalone x86 test, the check for building the > vDSO getrandom and chacaha tests looks at the architecture for the host > rather than the architecture for the target when deciding if they should > be built. Since the chacha test includes some assembler code this means > that cross building with x86 as either the target or host is broken. Use > a check for ARCH instead. > > This also handles s a small complication in conditionalizing on x86_64 > but not x86, which requires defining the standard SRCARCH variable and > being careful about which uname-m substitutions are done. > > Fixes: 4920a2590e91 ("selftests/vDSO: add tests for vgetrandom") > Signed-off-by: Mark Brown <broonie@xxxxxxxxxx> > Signed-off-by: Jason A. Donenfeld <Jason@xxxxxxxxx> > --- > Mark - is this okay with you? I fixed the issue I mentioned. That makes sense and appears to work for me so: Tested-by: Mark Brown <broonie@xxxxxxxxxx> Reviewed-by: Mark Brown <broonie@xxxxxxxxxx>
Attachment:
signature.asc
Description: PGP signature