Hi Lorenzo On Thu, Aug 29, 2024 at 8:44 AM Lorenzo Stoakes <lorenzo.stoakes@xxxxxxxxxx> wrote: > > > > > > Also, this is a really unusual way to send a series - why is this a 2/2 in > > > reply to the 1/2 and no cover letter? Why is this change totally unrelated > > > to the other patch? > > > 1/2 has a fix that 2/2 is depending on. That is the reason they are together. > > > Can you send this as a separate patch, preferably as an RFC so we can > > > ensure that we all agree on how mseal() should behave? > > > It is not an RFC because it doesn't change any semanic to mseal. The updated test will pass on linux main as well as 6.10. The increased coverage will help to prevent future regression, i.e. during refactoring. I will add a cover letter, split the tests and add more comments to help the review. Thanks -Jeff
