On 8/28/24 16:31, Mark Brown wrote:
On Tue, Aug 27, 2024 at 01:33:47PM +0100, Will Deacon wrote:
On Tue, Aug 27, 2024 at 10:48:51AM +0530, Dev Jain wrote:
A "%s" is missing in ksft_exit_fail_msg(); instead, use the newly
introduced ksft_exit_fail_perror(). Also, uint64_t corresponds to
unsigned 64-bit integer, so use %lx instead of %llx.
What's wrong with using %llx for a uint64_t? I think that part of the
code is fine as-is.
IIRC there's some printf format specifiers specific to uint64_t which
are probably a better choice here.
Well, then I will just send a patch fixing only the %s thing; I don't
want to get lost into format specifiers right now :)
