On 8/27/24 17:08, Shuah Khan wrote:
On 8/22/24 05:10, Dev Jain wrote:
On 8/22/24 08:33, Shuah Khan wrote:
On 8/21/24 00:15, Dev Jain wrote:
Rename sigaltstack to signal, and rename the existing test to
sigaltstack.c.
Can you elaborate on the benefits if renaming the test?
Also you have such a good information in the cover-letter for this
patch - it would be good to include it in the change log for this
one or the new test.
Okay.
The new test itself is good. I don't understand the value of renaming.
I can see the problems due to not being able to fix stables if the
existing test needs fixing. If there are good reasons for renaming,
I am all for it.
After looking into some git history, now I understand that "sas"
actually
has some meaning, although I still can't find its full-form :) I
thought that
sigaltstack would be a better name, but I guess sas is a subset of
sigaltstack
as part of SA_ONSTACK. So, let us drop the renaming of the test.
I assume you will be sending a new v6 patch series without the
renaming and just the
new test?
I had already sent it:
https://lore.kernel.org/all/20240822121415.3589190-1-dev.jain@xxxxxxx/
thanks,
-- Shuah
