Re: [PATCH net 00/15] mptcp: more fixes for the in-kernel PM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Jakub,

On 27/08/2024 04:29, Jakub Kicinski wrote:
> On Mon, 26 Aug 2024 17:58:59 +0200 Matthieu Baerts (NGI0) wrote:
>> Matthieu Baerts (NGI0) (15):
>>       mptcp: pm: reuse ID 0 after delete and re-add
>>       mptcp: pm: fix RM_ADDR ID for the initial subflow
>>       selftests: mptcp: join: check removing ID 0 endpoint
>>       mptcp: pm: send ACK on an active subflow
>>       mptcp: pm: skip connecting to already established sf
>>       mptcp: pm: reset MPC endp ID when re-added
>>       selftests: mptcp: join: check re-adding init endp with != id
>>       selftests: mptcp: join: no extra msg if no counter
>>       mptcp: pm: do not remove already closed subflows
>>       mptcp: pm: fix ID 0 endp usage after multiple re-creations
>>       selftests: mptcp: join: check re-re-adding ID 0 endp
>>       mptcp: avoid duplicated SUB_CLOSED events
>>       selftests: mptcp: join: validate event numbers
>>       mptcp: pm: ADD_ADDR 0 is not a new address
>>       selftests: mptcp: join: check re-re-adding ID 0 signal
> 
> The debug runner is failing mptcp-join-sh fairly consistently with
> these applied :(

Thank you for this notification!

It looks like the patch "selftests: mptcp: join: check re-re-adding ID 0
endp" is making the "delete and re-add" subtest longer: the connection
finishes while the validation is still ongoing. I guess I didn't see
this issue on my side, nor on MPTCP CI, because the Netdev CI is slower
(SLUB_DEBUG_ON?).

It is easy to fix, but I will wait for the other MPTCP series to be
applied, before sending a v2.

Cheers,
Matt
-- 
Sponsored by the NGI0 Core fund.





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux