Re: [PATCH] selftests/bpf: Fix incorrect parameters in NULL pointer checking

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Yonghong


Thank you very much for taking the time to review my patch.


On 8/22/24 05:03, Yonghong Song wrote:

On 8/19/24 7:34 PM, Hao Ge wrote:
From: Hao Ge <gehao@xxxxxxxxxx>

Smatch reported the following warning:
     ./tools/testing/selftests/bpf/testing_helpers.c:455 get_xlated_program()
     warn: variable dereferenced before check 'buf' (see line 454)

It seems correct,so let's modify it based on it's suggestion.

Actually,commit b23ed4d74c4d ("selftests/bpf: Fix invalid pointer
check in get_xlated_program()") fixed an issue in the test_verifier.c
once,but it was reverted this time.

Let's solve this issue with the minimal changes possible.

Reported-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
Closes: https://lore.kernel.org/all/1eb3732f-605a-479d-ba64-cd14250cbf91@stanley.mountain/ Fixes: b4b7a4099b8c ("selftests/bpf: Factor out get_xlated_program() helper")
Signed-off-by: Hao Ge <gehao@xxxxxxxxxx>

In the future, please change subject '[PATCH] ...' to '[PATCH bpf-next] ...'
so CI can properly test it.


OK, I understand. I will follow this rule in the future.


Acked-by: Yonghong Song <yonghong.song@xxxxxxxxx>





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux