On Thu, Aug 22, 2024 at 2:24 AM Tony Ambardar <tony.ambardar@xxxxxxxxx> wrote:
>
> From: Tony Ambardar <tony.ambardar@xxxxxxxxx>
>
> Fix missing newlines and extraneous terminal spaces in messages.
>
> Signed-off-by: Tony Ambardar <tony.ambardar@xxxxxxxxx>
> ---
> tools/lib/bpf/btf.c | 7 ++++---
> tools/lib/bpf/btf_dump.c | 2 +-
> tools/lib/bpf/btf_relocate.c | 2 +-
> tools/lib/bpf/libbpf.c | 4 ++--
> tools/lib/bpf/relo_core.c | 2 +-
> 5 files changed, 9 insertions(+), 8 deletions(-)
>
> diff --git a/tools/lib/bpf/btf.c b/tools/lib/bpf/btf.c
> index 32c00db3b91b..cf4f7bd7ff5c 100644
> --- a/tools/lib/bpf/btf.c
> +++ b/tools/lib/bpf/btf.c
> @@ -2940,7 +2940,8 @@ static int btf_ext_setup_info(struct btf_ext *btf_ext,
>
> /* If no records, return failure now so .BTF.ext won't be used. */
> if (!info_left) {
> - pr_debug("%s section in .BTF.ext has no records", ext_sec->desc);
> + pr_debug("%s section in .BTF.ext has no records\n",
> + ext_sec->desc);
if it fits in 100 characters, it stays in a single line, please don't touch that
> return -EINVAL;
> }
>
> @@ -3028,7 +3029,7 @@ static int btf_ext_parse_hdr(__u8 *data, __u32 data_size)
>
> if (data_size < offsetofend(struct btf_ext_header, hdr_len) ||
> data_size < hdr->hdr_len) {
> - pr_debug("BTF.ext header not found");
> + pr_debug("BTF.ext header not found\n");
> return -EINVAL;
> }
>
> @@ -3290,7 +3291,7 @@ int btf__dedup(struct btf *btf, const struct btf_dedup_opts *opts)
>
> d = btf_dedup_new(btf, opts);
> if (IS_ERR(d)) {
> - pr_debug("btf_dedup_new failed: %ld", PTR_ERR(d));
> + pr_debug("btf_dedup_new failed: %ld\n", PTR_ERR(d));
> return libbpf_err(-EINVAL);
> }
>
> diff --git a/tools/lib/bpf/btf_dump.c b/tools/lib/bpf/btf_dump.c
> index 894860111ddb..25e7c44d9f95 100644
> --- a/tools/lib/bpf/btf_dump.c
> +++ b/tools/lib/bpf/btf_dump.c
> @@ -1304,7 +1304,7 @@ static void btf_dump_emit_type_decl(struct btf_dump *d, __u32 id,
> * chain, restore stack, emit warning, and try to
> * proceed nevertheless
> */
> - pr_warn("not enough memory for decl stack:%d", err);
> + pr_warn("not enough memory for decl stack:%d\n", err);
nit: add space after ':' while you are at it?
> d->decl_stack_cnt = stack_start;
> return;
> }
[...]
