Re: [PATCH 2/4] kunit: Add macro to conditionally expose declarations to tests

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Aug 21, 2024 at 10:43 AM Michal Wajdeczko
<michal.wajdeczko@xxxxxxxxx> wrote:
>
> The DECLARE_IF_KUNIT macro will introduces identifiers only if
> CONFIG_KUNIT is enabled. Otherwise if CONFIG_KUNIT is not enabled
> no identifiers from the param list will be defined.
>
> Signed-off-by: Michal Wajdeczko <michal.wajdeczko@xxxxxxxxx>

Hello!

I like this macro. I think it could definitely be useful in declaring
static functions for KUnit testing in the header files. So I am happy
to add it.

We should also add this to the documentation at some point. I've been
wanting to revamp the visibility.h macros documentation anyways.

Reviewed-by: Rae Moar <rmoar@xxxxxxxxxx>

Thanks!

-Rae

> ---
> Cc: Rae Moar <rmoar@xxxxxxxxxx>
> Cc: David Gow <davidgow@xxxxxxxxxx>
> Cc: Lucas De Marchi <lucas.demarchi@xxxxxxxxx>
> ---
>  include/kunit/visibility.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
>
> diff --git a/include/kunit/visibility.h b/include/kunit/visibility.h
> index 0dfe35feeec6..1c23773f826c 100644
> --- a/include/kunit/visibility.h
> +++ b/include/kunit/visibility.h
> @@ -11,6 +11,13 @@
>  #define _KUNIT_VISIBILITY_H
>
>  #if IS_ENABLED(CONFIG_KUNIT)
> +    /**
> +     * DECLARE_IF_KUNIT - A macro that introduces identifiers only if
> +     * CONFIG_KUNIT is enabled. Otherwise if CONFIG_KUNIT is not enabled
> +     * no identifiers will be defined.
> +     * @body: identifiers to be introduced conditionally
> +     */
> +    #define DECLARE_IF_KUNIT(body...)  body
>      /**
>       * VISIBLE_IF_KUNIT - A macro that sets symbols to be static if
>       * CONFIG_KUNIT is not enabled. Otherwise if CONFIG_KUNIT is enabled
> @@ -26,6 +33,7 @@
>      #define EXPORT_SYMBOL_IF_KUNIT(symbol) EXPORT_SYMBOL_NS(symbol, \
>             EXPORTED_FOR_KUNIT_TESTING)
>  #else
> +    #define DECLARE_IF_KUNIT(body...)
>      #define VISIBLE_IF_KUNIT static
>      #define EXPORT_SYMBOL_IF_KUNIT(symbol)
>  #endif
> --
> 2.43.0
>





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux