* Pedro Falcato <pedro.falcato@xxxxxxxxx> [240818 02:36]: > On Sat, Aug 17, 2024 at 1:18 AM Pedro Falcato <pedro.falcato@xxxxxxxxx> wrote: > > @@ -983,6 +1019,41 @@ static void test_seal_munmap_vma_with_gap(bool seal) > > REPORT_TEST_PASS(); > > } > > > > +static void test_seal_munmap_partial_across_vmas(bool seal) > > +{ > > + void *ptr; > > + unsigned long page_size = getpagesize(); > > + unsigned long size = 2 * page_size; > > + int ret; > > + int prot; > > + > > + /* > > + * Check if a partial mseal (that results in two vmas) works correctly. > > + * It might unmap the first, but it'll never unmap the second (msealed) vma. > > + */ > > Bah, obviously this comment isn't true, munmap is never partial. > I'll change this locally for v4 if there ends up being one. Besides this comment, the patch looks good. Reviewed-by: Liam R. Howlett <Liam.Howlett@xxxxxxxxxx>