On Sun, Aug 18, 2024 at 11:54 PM Mina Almasry <almasrymina@xxxxxxxxxx> wrote: > > v20: https://patchwork.kernel.org/project/netdevbpf/list/?series=879373&state=* > ==== > > v20 aims to resolve a couple of bug reports against v19, and addresses > some review comments around the page_pool_check_memory_provider > mechanism. > > Major changes: > - Test edge cases such as header split disabled in selftest. > - Change `offset = 0` back to `offset = offset - start` to resolve issue > found in RX path by Taehee (thanks!) > - Address a few comments around page_pool_check_memory_provider() from > Pavel & Jakub. > - Removed some unnecessary includes across various patches in the > series. > - Removed unnecessary EXPORT_SYMBOL(page_pool_mem_providers) (Jakub). > - Fix regression caused by incorrect dev_get_max_mp_channel check, along > with rename (Jakub). > Looks like in this iteration I resolved the previous test failure, but introduced a build regression with certain configs: ld: vmlinux.o: in function `netdev_rx_queue_restart': (.text+0x6a4133): undefined reference to `page_pool_check_memory_provider' make[3]: *** [../scripts/Makefile.vmlinux:34: vmlinux] Error 1 make[2]: *** [/home/kunit/testing/Makefile:1156: vmlinux] Error 2 make[1]: *** [/home/kunit/testing/Makefile:224: __sub-make] Error 2 make: *** [Makefile:224: __sub-make] Error 2 Looks like I'm not build testing with enough config variations (in this case CONFIG_NET=y but CONFIG_PAGE_POOL=n). I've fixed the issue locally and added a test to my presubmit checks with this config and a couple of risky others. Sorry about that.
