On Wed, 14 Aug 2024 17:57:48 -0700, Jakub Kicinski wrote: > On Wed, 14 Aug 2024 17:56:51 -0700 Jakub Kicinski wrote: > > On Wed, 14 Aug 2024 19:15:15 +0000 Abhinav Jain wrote: > > > Changes in v6: > > > Use XFAIL for ethtool operations that are unsupported instead of SKIP. > > > > One more: > > > > tools/testing/selftests/net/netdevice.sh: echo "SKIP: $netdev: set IP address" > > > > I think the SKIP -> XFAIL conversion should be a separate patch (for > > total of 3 patches in the series). > > P.S. and please change the subject to [PATCH net-next], it's a net-next > change, not a net fix. I have sent v7 now with net-next instead of net: https://lore.kernel.org/all/20240815105924.1389290-1-jain.abhinav177@xxxxxxxxx For set IP address part, I have added logic to XFAIL if veth pair was created and to SKIP if that's not the case in third patch of the series as directed above. Right now, there is no logic to set IP address in the script for normal interfaces either and it is a TODO as well. I will focus on it next after this one is applied. Thank you for all the help Jakub.
