On Mon, 12 Aug 2024 11:39:44 -0700, Kuniyuki Iwashima wrote:
> Fixes: tag is needed here (no space between SOB tag)
Thank you, I have added it in v2 here:
> I don't remember why I defined expected_buf as (void *), but more simple
> fix would be the following ?
>
> ---8<---
> diff --git a/tools/testing/selftests/net/af_unix/msg_oob.c b/tools/testing/selftests/net/af_unix/msg_oob.c
> index 16d0c172eaeb..535eb2c3d7d1 100644
> --- a/tools/testing/selftests/net/af_unix/msg_oob.c
> +++ b/tools/testing/selftests/net/af_unix/msg_oob.c
> @@ -209,7 +209,7 @@ static void __sendpair(struct __test_metadata *_metadata,
>
> static void __recvpair(struct __test_metadata *_metadata,
> FIXTURE_DATA(msg_oob) *self,
> - const void *expected_buf, int expected_len,
> + const char *expected_buf, int expected_len,
> int buf_len, int flags)
> {
> int i, ret[2], recv_errno[2], expected_errno = 0;
> ---8<---
Yes, I completely missed that. I have sent a v2, please review:
lore.kernel.org/all/20240812191122.1092806-1-jain.abhinav177@xxxxxxxxx
