Re: [PATCH net-next v2] selftests: net: py: support verbose printing, display executed commands

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 9 Aug 2024 14:36:17 +0200 Petr Machata wrote:
> > +    env_level = env.get('VERBOSE')
> > +    set_verbosity(env_level)
> > +  
> 
> Actually, the ksft_setup() here was merged last week, and I think that
> would be a better place to put this stuff. It already handles
> DISRUPTIVE, it should IMHO handle VERBOSE as well.

I was wondering about that too, FWIW, but the counter argument is that
VERBOSE has little to do with ksft. It doesn't even include the #
prefix on the list it outputs by itself (unlike ksft_pr() which does).

Maybe we do as you suggest but rename verbose() to ksft_dbg() and
make it act more like ksft_pr()?




[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux