On Thu, 8 Aug 2024 12:24:51 +0000 Abhinav Jain wrote: > Check if the netdev list is empty and create veth pair to be used for > feature on/off testing. > Remove the veth pair after testing is complete. A number of checks now return SKIP because veth doesn't support all ethtool APIs. In netdev selftests we try to make sure SKIP is only used when test cannot be performed because of limitations of the environment. For example some tool is not installed, kernel doesn't have a config. Something that the person running the test is able to fix by fixing how the test is run. Running this test on veth will always SKIP, nothing CI system can do. Please make the test use the keyword XFAIL instead of SKIP when functionality is not supported by the underlying driver. -- pw-bot: cr
