On Tue, Jul 30, 2024 at 4:38 AM Markus Elfring <Markus.Elfring@xxxxxx> wrote: > > … > > +++ b/include/net/devmem.h > > @@ -0,0 +1,115 @@ > … > > +#ifndef _NET_DEVMEM_H > > +#define _NET_DEVMEM_H > … > > I suggest to omit leading underscores from such identifiers. > https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier > I was gonna apply this change, but I ack'd existing files and I find that all of them include leading underscores, including some very recently added files like net/core/page_pool_priv.h. I would prefer to stick to existing conventions if that's OK, unless there is widespread agreement to the contrary. -- Thanks, Mina
