On 2024-08-03 11:40:24+0000, Willy Tarreau wrote: > On Sun, Jul 28, 2024 at 12:10:01PM +0200, Thomas Weißschuh wrote: > > Avoid needing relative includes. > > I'm not opposed, but what's the benefit ? IMHO relative paths are > generally more flexible and robust. you could imagine a completely > made up example in which you have a symlink to selftests/nolibc in > your home dir, which works perfectly with relative paths when you > cd into it while it would not anymore with absolute paths (unless > you use cd -P). This commit is solely about relative includes in the nolibc-test Makefile. The actual code is unaffected. include ../../../scripts/utilities.mak -> include $(srctree)/tools/scripts/utilities.mak This commit is not necessary, just a cleanup. IMO consistently using $(srctree) is nicer. And yes the message for this commit is really not great. > Thus if we are decided to lose that flexibility at least it should > be argumented in the commit message. > > Thanks, > Willy
