On 7/29/24 7:09 PM, Randy Dunlap wrote: > > > On 7/29/24 1:07 AM, Muhammad Usama Anjum wrote: >> On 7/27/24 10:35 PM, Yury Norov wrote: >>> On Fri, Jul 26, 2024 at 04:06:57PM +0500, Muhammad Usama Anjum wrote: >>>> Rename module to bitmap_kunit and rename the configuration option >>>> compliant with kunit framework. >>> >>> ... , so those enabling bitmaps testing in their configs by setting >>> "CONFIG_TEST_BITMAP=y" will suddenly get it broken, and will likely >>> not realize it until something nasty will happen. >> CONFIG_TEST_BITMAP was being enabled by the kselftest suite lib. The bitmap >> test and its config option would disappear. The same test can be run by >> just enabling KUNIT default config option: >> >> KUNIT_ALL_TESTS=y enables this bitmap config by default. >> >>> >>> Sorry, NAK for config rename. >>> > > I agree with Yury. Using KUNIT takes away test coverage for people who > are willing to run selftests but not use KUNIT. How is a kselftest useful when it doesn't even check results of the tests and report failures when they happen? -- BR, Muhammad Usama Anjum
