On 7/27/24 12:26 AM, Shuah Khan wrote:
> On 7/26/24 05:06, Muhammad Usama Anjum wrote:
>> In this series, test_bitmap is being converted to kunit test. Multiple
>> patches will make the review process smooth.
>>
>> - Patch-1: Convert the tests in lib/test_bitmap.c to kunit
>> - Patch-2: Rename the lib/test_bitmap.c to lib/bitmap_kunit.c and other
>> configuration options
>> - Patch-3: Remove the bitmap.sh selftest
>>
>> Muhammad Usama Anjum (3):
>> bitmap: convert test_bitmap to KUnit test
>> bitmap: Rename module
>> selftests: lib: remove test_bitmap
>>
>> MAINTAINERS | 2 +-
>> lib/Kconfig.debug | 15 +-
>> lib/Makefile | 2 +-
>> lib/{test_bitmap.c => bitmap_kunit.c} | 624 ++++++++++++--------------
>> tools/testing/selftests/lib/Makefile | 2 +-
>> tools/testing/selftests/lib/bitmap.sh | 3 -
>> tools/testing/selftests/lib/config | 1 -
>> 7 files changed, 295 insertions(+), 354 deletions(-)
>> rename lib/{test_bitmap.c => bitmap_kunit.c} (70%)
>> delete mode 100755 tools/testing/selftests/lib/bitmap.sh
>>
>
> Can you tell me how this conversion helps?
>
> It is removing the ability to run bitmap tests during boot.
> It doesn't make sense to blindly convert all test under lib
> to kunit - Nack on this change or any change that takes away
> the ability to run tests and makes them dependent on kunit.
Let's discuss this on discussion thread [1].
[1]
https://lore.kernel.org/all/a3083ad4-e9dc-40da-bf57-8391bcd96a6c@xxxxxxxxxxxxx
>
> thanks,
> -- Shuah
--
BR,
Muhammad Usama Anjum
