On 7/26/24 02:16, Muhammad Usama Anjum wrote:
On 7/25/24 7:44 PM, Shuah Khan wrote:
On 7/25/24 05:08, Muhammad Usama Anjum wrote:
The user test suite has only one test, test_user_copy which loads
test_user_copy module for testing. But test_user_copy module has already
been converted to kunit (see fixes). Hence remove the entire suite.
Fixes: cf6219ee889f ("usercopy: Convert test_user_copy to KUnit test")
Remove fixes tag - this isn't a fix and we don't want this propagating
to stable releases without kunit test for this.
The user test suite has been failing since cf6219ee889f as the test module
wasn't found. So this is fixing the failure of kselftest. It just causes
noise and may mask other failures. If you still think that fixes isn't
needed, I can send a new version by removing the fixes tag.
In which case this information should have been part of the change log to
make it clear this is a fix. Fixes tag should also mention the releases
this is applicable to so this patch doesn't make it to stables releases
without cf6219ee889f - so this test still runs.
If you are adding Fixes tag it should mention the releases this is
applicable to. Can you get me that information?
thanks,
-- Shuah
