Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 12. 07. 24 10:21, Takashi Iwai wrote:
On Thu, 11 Jul 2024 18:19:25 +0200,
Mark Brown wrote:

On Thu, Jul 11, 2024 at 06:08:38PM +0200, Jaroslav Kysela wrote:
On 11. 07. 24 16:33, Mark Brown wrote:

Address this by replacing our use of card numbers with card names which are
more likely to be stable across runs. We use the long name since in the

I think that a combination of card number and card ID may be sufficient (and
a compromise). It's shorter and user-friendly. Additionally, a table may be
printed at the beginning of report with card number, card ID and long card
name for further processing and identification.

These don't help, the problem is that anything which includes the card
number in the test name result is going to result in unstable test names
depending on race conditions at boot.  There are automated systems that
parse kselftest output generically, I'm not sure there's a great deal of
enthusiasm for writing a custom parser for the ALSA selftests
specifically.

OTOH, longname can be really ugly to read, and it can vary because it
often embeds address or irq numbers in the string.

If a general name is the goal, how about using shortname instead?

Or use id field, as Jaroslav suggested, but without the card number
suffix; then it's unique among multiple cards.

I prefer this (use only ID field). This string can be also set in the user space using sysfs/udev, so the administrator may change it if the default is not ideal.

					Jaroslav

--
Jaroslav Kysela <perex@xxxxxxxx>
Linux Sound Maintainer; ALSA Project; Red Hat, Inc.





[Index of Archives]     [Linux Wireless]     [Linux Kernel]     [ATH6KL]     [Linux Bluetooth]     [Linux Netdev]     [Kernel Newbies]     [Share Photos]     [IDE]     [Security]     [Git]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux ATA RAID]     [Samba]     [Device Mapper]

  Powered by Linux