On 7/10/24 9:16 PM, Shuah Khan wrote: > On 7/10/24 03:37, Muhammad Usama Anjum wrote: >> This patch brings just readability implements by using kselftests wrappers >> instead of manual pass/fail test cases counting. It has been on mailing >> list from several months now. Please can someone ack or nack? >> > > Okay. I think I responded to your other patches that are adding TAP > to individual tests when kselftest wrapped does it for you based on > return values. The current test doesn't return any exit value (hence implicitly always 0 is returned). The return value in addition to some other changes is getting fixed in this patch. > > The reason I don't want to take this patch is if you run the test > using the recommended method: > > make -C tools/testing/selftests/vDSO/ run_tests you will get the > TAP output because lib.mk runtests framework takes care of this. This patch is required to correctly return the value so that runtests fraework can correctly mark the result of the test. > > or > > make kselftest TARGETS=vDSO will do the same. > > Please don't send TAP conversions for individual runs. You will > start seeing duplicate TAP output which will make it unreadable. > > Run the test using make -C or make kselftest TARGETS before > investing time to concert to TAP. I am not going to take TAP > conversions patches if make -C or make kselftest TARGETS > shows TAP. > > thanks, > -- Shuah > -- BR, Muhammad Usama Anjum
