On 7/1/24 03:38, srinivas pandruvada wrote:
On Mon, 2024-07-01 at 13:36 +0500, Muhammad Usama Anjum wrote:
Soft reminder
On 5/22/24 10:06 PM, Muhammad Usama Anjum wrote:
Conform the layout, informational and status messages to TAP. No
functional change is intended other than the layout of output
messages.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@xxxxxxxxxxxxx>
---
Okay. I think I responded to your other patches that are adding TAP
to individual tests when kselftest wrapped does it for you based on
return values.
The reason I don't want to take this patch is if you run the test
using the recommended method:
make -C tools/testing/selftests/vDSO/ run_tests you will get the
TAP output because lib.mk runtests framework takes care of this.
or
make kselftest TARGETS=vDSO will do the same.
Please don't send TAP conversions for individual runs. You will
start seeing duplicate TAP output which will make it unreadable.
Run the test using make -C or make kselftest TARGETS before
investing time to concert to TAP. I am not going to take TAP
conversions patches if make -C or make kselftest TARGETS
shows TAP.
thanks,
-- Shuah
